code-423n4 / 2021-08-notional-findings

3 stars 0 forks source link

Unused variables #52

Open code423n4 opened 3 years ago

code423n4 commented 3 years ago

Handle

pauliax

Vulnerability details

Impact

Unused variables, e.g.: int256 internal constant ETH_DECIMAL_PLACES = 18; remove it to save some gas or use it where intended.

jeffywu commented 3 years ago

Unused constants do not have an impact on deployed code.

ghoul-sol commented 3 years ago

Technically, it makes deployment more expensive. Keeping as is.