code-423n4 / 2021-08-notional-findings

3 stars 0 forks source link

Open TODOs in `ERC1155Action` #63

Open code423n4 opened 3 years ago

code423n4 commented 3 years ago

Handle

cmichel

Vulnerability details

Vulnerability Details

The ERC1155Action._checkPostTransferEvent has open TODOs:

// TODO: retrieve revert string
require(status, "Call failed");

Impact

Open TODOs can hint at programming or architectural errors that still need to be fixed.

Recommended Mitigation Steps

Resolve the TODO and bubble up the error.