search

code-423n4 / 2021-08-notional-findings

3 stars 0 forks source link

NoteERC20 _authorizeUpgrade not implemented #75

Open code423n4 opened 3 years ago

code423n4 commented 3 years ago

Handle

cmichel

Vulnerability details

Vulnerability Details

The NoteERC20._authorizeUpgrade function is not implemented.

Recommended Mitigation Steps

Double-check if this is the expected behavior.

jeffywu commented 3 years ago

It implements an onlyOwner check which is the intended behavior. https://github.com/code-423n4/2021-08-notional/blob/main/contracts/external/governance/NoteERC20.sol#L130

ghoul-sol commented 3 years ago

per sponsor comment making this invalid