search

code-423n4 / 2021-08-notional-findings

3 stars 0 forks source link

Missing SPDX Identifier #95

Open code423n4 opened 3 years ago

code423n4 commented 3 years ago

Handle

leastwood

Vulnerability details

Impact

The MockWETH.sol contract is missing an SPDX identifier which correctly licenses the contract for open source development.

Proof of Concept

https://github.com/code-423n4/2021-08-notional/blob/main/contracts/mocks/MockWETH.sol

Tools Used

Compiler warning

Recommended Mitigation Steps

Consider adding // SPDX-License-Identifier: GPL-3.0-only to the top of the MockWETH.sol file.

jeffywu commented 3 years ago

I don't think we should pay any reward for this, this is a non-issue and the mock contracts are out of scope.

ghoul-sol commented 3 years ago

contracts out of scope, invalid