search

code-423n4 / 2021-08-notional-findings

3 stars 0 forks source link

Non-existent `nERC1155Interface.supportsInterface.selector` #97

Open code423n4 opened 3 years ago

code423n4 commented 3 years ago

Handle

leastwood

Vulnerability details

Impact

Router.sol has an unused non-existent selector in Router.getRouterImplementation which references nERC1155Interface.sol.

Proof of Concept

https://github.com/code-423n4/2021-08-notional/blob/main/interfaces/notional/nERC1155Interface.sol https://github.com/code-423n4/2021-08-notional/blob/main/contracts/external/Router.sol#L139

Tools Used

Compiler warning

Recommended Mitigation Steps

Router.sol:L139 can be safely removed so as to avoid potential function selector conflicts.

jeffywu commented 3 years ago

The supportsInterface function call is in the inherited IERC165 interface.

ghoul-sol commented 3 years ago

per sponsor comment, invalid