search

code-423n4 / 2021-08-realitycards-findings

1 stars 0 forks source link

Access Control Constants #38

Open code423n4 opened 3 years ago

code423n4 commented 3 years ago

Handle

hickuphh3

Vulnerability details

Impact

It would be better to define all access control roles (UBER_OWNER, OWNER, GOVERNOR etc.) in a single contract / library, then have other contracts import it. This prevents potential spelling or duplication errors across multiple contracts.

Splidge commented 3 years ago

Having them all in one contract would put the Factory and the Market over the size limit (they're that close 😟), a library would be a better solution but we aren't going to change this at such a late stage in the project. (probably do this in V2)