search

code-423n4 / 2021-08-realitycards-findings

1 stars 0 forks source link

RCLeaderboard: Erroneous comment #43

Open code423n4 opened 3 years ago

code423n4 commented 3 years ago

Handle

hickuphh3

Vulnerability details

Impact

The comments above the event declarations were probably copied over from RCOrderbook. They should be modified to refer to the leaderboard.

Recommended Mitigation Steps

/// @dev emitted every time a user is added to the leaderboard
event LogAddToLeaderboard(address _user, address _market, uint256 _card);
/// @dev emitted every time a user is removed from the leaderboard
event LogRemoveFromLeaderboard(
    address _user,
    address _market,
    uint256 _card
);
Splidge commented 3 years ago

probably copied over from RCOrderbook

Exactly. I'll correct this.

0xean commented 3 years ago 
1 — Low: Low: Assets are not at risk. State handling, function incorrect as to spec, issues with comments.
Splidge commented 3 years ago

Fixed here