code-423n4 / 2021-08-yield-findings

1 stars 0 forks source link

Missing emits for events #51

Open code423n4 opened 3 years ago

code423n4 commented 3 years ago

Handle

0xRajeev

Vulnerability details

Impact

Few events are missing emits which prevents the intended data from being observed easily by off-chain interfaces.

Proof of Concept

https://github.com/code-423n4/2021-08-yield/blob/4dc46470e616dd0cbd9db9b4742e36c4d809e02c/contracts/yieldspace/Strategy.sol#L48-L49

Tools Used

Manual Analysis

Recommended Mitigation Steps

Add emits or remove event declarations.

alcueca commented 3 years ago