search

code-423n4 / 2021-08-yield-findings

1 stars 0 forks source link

Methods should be external instead of public #61

Open code423n4 opened 3 years ago

code423n4 commented 3 years ago

Handle

hickuphh3

Vulnerability details

Impact

As brought up in a previous audit issue, "the suggestion of changing all public auth functions to external auth will be applied". The same should therefore be done for the new contracts Strategy.sol and ERC20Rewards.sol, since all public methods in it aren't called internally.

alcueca commented 3 years ago

Fix

alcueca commented 3 years ago

Fix (Strategy)

ghoul-sol commented 3 years ago

42