code-423n4 / 2021-09-defiprotocol-findings

1 stars 0 forks source link

after sensitive action event should be emitted #116

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Handle

JMukesh

Vulnerability details

Impact

After action like setMinLicenseFee(), setAuctionDecrement(), setAuctionMultiplier(), setBondPercentDiv() and setOwnerSplit() affect the publisher, so track these data offchain event should be emitted , specially in case of setOwnersplit()

Proof of Concept

https://github.com/code-423n4/2021-09-defiProtocol/blob/52b74824c42acbcd64248f68c40128fe3a82caf6/contracts/contracts/Factory.sol#L39

Tools Used

manual review

Recommended Mitigation Steps

GalloDaSballo commented 2 years ago

Duplicate of #123