search

code-423n4 / 2021-09-defiprotocol-findings

1 stars 0 forks source link

Missing zero-address checks #140

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Handle

0xRajeev

Vulnerability details

Impact

Zero-address checks are in general a best-practice. While this is performed in most places, the Factory constructor is missing these checks.

Proof of Concept

https://github.com/code-423n4/2021-09-defiProtocol/blob/52b74824c42acbcd64248f68c40128fe3a82caf6/contracts/contracts/Factory.sol#L19-L20

Tools Used

Manual Analysis

Recommended Mitigation Steps

Add zero-address checks.

frank-beard commented 2 years ago

not an exploit

GalloDaSballo commented 2 years ago

Duplicate of #86