code-423n4 / 2021-09-defiprotocol-findings

1 stars 0 forks source link

Avoiding initializations to default values will save gas #142

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Handle

0xRajeev

Vulnerability details

Impact

While it is generally a good idea to explicitly initialize variables, the default values of uints are 0 and do not require initializations to default values. Avoiding these will save gas.

Proof of Concept

https://github.com/code-423n4/2021-09-defiProtocol/blob/52b74824c42acbcd64248f68c40128fe3a82caf6/contracts/contracts/Factory.sol#L21

https://github.com/code-423n4/2021-09-defiProtocol/blob/52b74824c42acbcd64248f68c40128fe3a82caf6/contracts/contracts/Factory.sol#L33

Tools Used

Manual Analysis

Recommended Mitigation Steps

Avoid initializations to default values

GalloDaSballo commented 2 years ago

Duplicate of #39