search

code-423n4 / 2021-09-defiprotocol-findings

1 stars 0 forks source link

Event params are of no practical value #163

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

Handle

hack3r-0m

Vulnerability details

https://github.com/code-423n4/2021-09-defiProtocol/blob/main/contracts/contracts/Factory.sol#L87

emit BasketLicenseProposed(msg.sender, tokenName);

same event can be emitted with excat same parameters multiple times causing confusion to actors relying on it.

Mitigation:

Add proposal id or some other parameter

GalloDaSballo commented 2 years ago

The sponsor confirms

I can see how returning the id of the proposal would provide more info