Closed code423n4 closed 2 years ago
leastwood
There are a number of bools in Auction.sol which can be combined to fit into a single slot. This saves gas on each deployment of the Auction.sol contract.
bools
Auction.sol
https://github.com/code-423n4/2021-09-defiProtocol/blob/main/contracts/contracts/Auction.sol#L16-L21
Manual code review
Consider implementing proper slot packing in all contracts.
Duplicate of #109
Handle
leastwood
Vulnerability details
Impact
There are a number of
bools
inAuction.sol
which can be combined to fit into a single slot. This saves gas on each deployment of theAuction.sol
contract.Proof of Concept
https://github.com/code-423n4/2021-09-defiProtocol/blob/main/contracts/contracts/Auction.sol#L16-L21
Tools Used
Manual code review
Recommended Mitigation Steps
Consider implementing proper slot packing in all contracts.