search

code-423n4 / 2021-09-defiprotocol-findings

1 stars 0 forks source link

Lack of maxLicenseFee to protect users against greedy publishers #170

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Handle

0xRajeev

Vulnerability details

Impact

While the protocol enforces a minLicenseFee, there is no concept of a maxLicenseFee in the protocol that prevents greedy publishers from charging an absurd licensing fee for using the protocol. A maxLicenseFee will help protect users against greedy publishers.

Proof of Concept

https://github.com/code-423n4/2021-09-defiProtocol/blob/52b74824c42acbcd64248f68c40128fe3a82caf6/contracts/contracts/Factory.sol#L29

Tools Used

Manual Analysis

Recommended Mitigation Steps

Consider a protocol maxLicenseFee to protect users against greedy publishers.

GalloDaSballo commented 2 years ago

Agree with finding

Since the warden already submitted this finding via #173 , I'll set this to invalid