Open code423n4 opened 2 years ago
0xRajeev
Maximum approvals are widely considered as unsafe if the approved contract becomes compromised/malicious.
https://github.com/code-423n4/2021-09-defiProtocol/blob/52b74824c42acbcd64248f68c40128fe3a82caf6/contracts/contracts/Basket.sol#L226
Manual Analysis
Consider redesigning for approvals on specific amounts.
Given the lack of a specific attack vector am downgrading to non-critical
Handle
0xRajeev
Vulnerability details
Impact
Maximum approvals are widely considered as unsafe if the approved contract becomes compromised/malicious.
Proof of Concept
https://github.com/code-423n4/2021-09-defiProtocol/blob/52b74824c42acbcd64248f68c40128fe3a82caf6/contracts/contracts/Basket.sol#L226
Tools Used
Manual Analysis
Recommended Mitigation Steps
Consider redesigning for approvals on specific amounts.