Open code423n4 opened 2 years ago
hack3r-0m
https://github.com/code-423n4/2021-09-defiProtocol/blob/main/contracts/contracts/Auction.sol#L146
transfer() might return false instead of reverting, in this case, ignoring return value leads to considering it successful.
transfer()
use safeTransfer() or check the return value if length of returned data is > 0.
safeTransfer()
Agree with finding, agree with severity given the specific example given as the funds would be stuck in the contract
Handle
hack3r-0m
Vulnerability details
https://github.com/code-423n4/2021-09-defiProtocol/blob/main/contracts/contracts/Auction.sol#L146
transfer()
might return false instead of reverting, in this case, ignoring return value leads to considering it successful.use
safeTransfer()
or check the return value if length of returned data is > 0.