search

code-423n4 / 2021-09-defiprotocol-findings

1 stars 0 forks source link

Use safeTransfer instead of transfer #196

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

Handle

hack3r-0m

Vulnerability details

https://github.com/code-423n4/2021-09-defiProtocol/blob/main/contracts/contracts/Auction.sol#L146

transfer() might return false instead of reverting, in this case, ignoring return value leads to considering it successful.

use safeTransfer() or check the return value if length of returned data is > 0.

GalloDaSballo commented 2 years ago

Agree with finding, agree with severity given the specific example given as the funds would be stuck in the contract