code-423n4 / 2021-09-defiprotocol-findings

1 stars 0 forks source link

multiply before divide #197

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Handle

hack3r-0m

Vulnerability details

https://github.com/code-423n4/2021-09-defiProtocol/blob/main/contracts/contracts/Auction.sol#L146

Solidity integer division might truncate. As a result, performing multiplication before division can sometimes avoid loss of precision.

GalloDaSballo commented 2 years ago

The line mentioned in the finding doesn't have a division Invalid as it seems like this is spam