code-423n4 / 2021-09-defiprotocol-findings

1 stars 0 forks source link

Functions that can be external not public #212

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Handle

pauliax

Vulnerability details

Impact

Functions like publishNewIndex deleteNewIndex, changeLicenseFee, changePublisher, etc can be 'external' not 'public' to save some gas as they are never called from the same contract.

frank-beard commented 2 years ago

https://github.com/code-423n4/2021-09-defiprotocol-findings/issues/240

GalloDaSballo commented 2 years ago

Duplicate of #240