GalloDaSballo
commented
2 years ago Appreciate the wardens thoughts, agree with the points, except the error message, you can just add a comment to the side and when debugging with sources you'll get the line anyway
Handle
pauliax
Vulnerability details
Impact
Style issues that you may want to apply or reject, no impact on security. Grouping them together as one submission to reduce waste. Consider fixing or ignoring them, up to you.
I think it would be convenient if the contract Factory exposed a function to retrieve the number of proposals (_proposals.length) as _proposals are stored in a private variable and it may be difficult to decode.
Variable name ONE_DAY is not very informative and is a bit misleading as at first I expected to see a time variable but apparently, it is expressed in blocks. Consider renaming this to BLOCKS_PER_DAY or something like that. Similarly, bondTimestamp is also a misleading name, better name it bondBlock or similar.
Consider adding revert messages so that end users can get at least a little bit of understanding of what went wrong. This will increase the deployment costs but improve the UX. At least consider adding a short indicator code.