The Auction.initialize function accepts a factory_ parameter.
However, as this contract is always initialized directly from the factory, it can just use msg.sender.
Recommended Mitigation Steps
Removing the additional factory_ parameter and using msg.sender instead will save gas.
This is already done for the other Basket contract.
Handle
cmichel
Vulnerability details
The
Auction.initialize
function accepts afactory_
parameter. However, as this contract is always initialized directly from the factory, it can just usemsg.sender
.Recommended Mitigation Steps
Removing the additional
factory_
parameter and usingmsg.sender
instead will save gas. This is already done for the otherBasket
contract.