search

code-423n4 / 2021-09-defiprotocol-findings

1 stars 0 forks source link

No require messages #247

Closed code423n4 closed 2 years ago

code423n4 commented 3 years ago

Handle

goatbug

Vulnerability details

Impact

No require messages throughout contracts.

Will be difficult to debug and figure out what is happening when things are failing, for users and developers. I.e. Slower time to identify errors.

    require(auction.auctionOngoing() == false);
    require(amount > 0);
    require(balanceOf(msg.sender) >= amount);

Proof of Concept

Provide direct links to all referenced code in GitHub. Add screenshots, logs, or any other relevant proof that illustrates the concept.

Tools Used

Recommended Mitigation Steps

frank-beard commented 2 years ago

https://github.com/code-423n4/2021-09-defiprotocol-findings/issues/258

GalloDaSballo commented 2 years ago

Disagree as with all other of these