code-423n4 / 2021-09-defiprotocol-findings

1 stars 0 forks source link

Naming #250

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

Handle

goatbug

Vulnerability details

Impact

Line 58 Auction bondTimestamp = block.number;

Setting a variable labelled as a timestamp to a block number, this is misleading and causing errors on the timelocks.

Timestamp != blocknumber

Proof of Concept

Provide direct links to all referenced code in GitHub. Add screenshots, logs, or any other relevant proof that illustrates the concept.

Tools Used

Recommended Mitigation Steps

frank-beard commented 2 years ago

not an exploit

GalloDaSballo commented 2 years ago

Agree with finding, the variable name can be improved At the same time, this is not a vulnerability nor any mistake, as such this is a non-critical finding