code-423n4 / 2021-09-defiprotocol-findings

1 stars 0 forks source link

`deleteNewIndex` can be external #259

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Handle

0xsanson

Vulnerability details

Impact

In Basket.sol, function deleteNewIndex can be external, since it's not used inside the contract. This can save some gas.

Proof of Concept

https://github.com/code-423n4/2021-09-defiProtocol/blob/main/contracts/contracts/Basket.sol#L207

frank-beard commented 2 years ago

https://github.com/code-423n4/2021-09-defiprotocol-findings/issues/240

GalloDaSballo commented 2 years ago

Duplicate of #240