Closed code423n4 closed 2 years ago
0xsanson
In Basket.sol, function deleteNewIndex can be external, since it's not used inside the contract. This can save some gas.
deleteNewIndex
https://github.com/code-423n4/2021-09-defiProtocol/blob/main/contracts/contracts/Basket.sol#L207
https://github.com/code-423n4/2021-09-defiprotocol-findings/issues/240
Duplicate of #240
Handle
0xsanson
Vulnerability details
Impact
In Basket.sol, function
deleteNewIndex
can be external, since it's not used inside the contract. This can save some gas.Proof of Concept
https://github.com/code-423n4/2021-09-defiProtocol/blob/main/contracts/contracts/Basket.sol#L207