code-423n4 / 2021-09-defiprotocol-findings

1 stars 0 forks source link

`proposeBasketLicense` can be external #262

Closed code423n4 closed 3 years ago

code423n4 commented 3 years ago

Handle

0xsanson

Vulnerability details

Impact

The function Factory.proposeBasketLicense isn't used inside Factory contract, so it can be set to external to save gas.

Proof of Concept

https://github.com/code-423n4/2021-09-defiProtocol/blob/main/contracts/contracts/Factory.sol#L65

frank-beard commented 3 years ago

https://github.com/code-423n4/2021-09-defiprotocol-findings/issues/240

GalloDaSballo commented 3 years ago

Duplicate of #240