search

code-423n4 / 2021-09-defiprotocol-findings

1 stars 0 forks source link

Add nonreentrant modifiers to external methods in 2 files #270

Open code423n4 opened 3 years ago

code423n4 commented 3 years ago

Handle

tensors

Vulnerability details

I recommend adding reentrancy checks throughout Basket.sol and Auction.sol using a mutex lock. Many external calls are made to potentially unsafe token contracts. In the case that not all token contracts are properly vetted, this preventative step could be worthwhile.

GalloDaSballo commented 2 years ago

Agree with finding, reentrancy check will help