code-423n4 / 2021-09-defiprotocol-findings

1 stars 0 forks source link

No input validation on parameter changes #274

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

Handle

tensors

Vulnerability details

Impact

Consider adding sanity checks on these 4 methods, similar to the requirement on the setOwnerSplit method.

Proof of Concept

https://github.com/code-423n4/2021-09-defiProtocol/blob/52b74824c42acbcd64248f68c40128fe3a82caf6/contracts/contracts/Factory.sol#L39-L54

GalloDaSballo commented 2 years ago

Agree with the finding