Closed code423n4 closed 2 years ago
this is intended as it refers to the block time/block number
Because the sponsor intended TIMELOCK_DURATION to be in blocks, the finding is invalid
However, after all this flagging, I highly recommend the sponsor considers renaming the constant or to add a comment to make it obvious this is a block measure, not hours
Handle
jonah1005
Vulnerability details
Impact
TIMELOCK_DURATION is set to 46024. It should be 606024; Basket.sol#L15
Proof of Concept
This would fail.
Tools Used
None
Recommended Mitigation Steps
Use
1 days
instead.