code-423n4 / 2021-09-defiprotocol-findings

1 stars 0 forks source link

Lack of event emission after sensitive actions #88

Closed code423n4 closed 2 years ago

code423n4 commented 3 years ago

Handle

WatchPug

Vulnerability details

Serveral functions of the contracts does not emit relevant events after executing the sensitive actions of changing various critical parameters, includes:

Factory.sol

Auction.sol

Basket.sol

Recommended Mitigation Steps

Consider emitting events after sensitive changes take place, to facilitate tracking and notify off-chain clients following the contract’s activity.

GalloDaSballo commented 2 years ago

Duplicate of #123