code-423n4 / 2021-09-sushimiso-findings

0 stars 0 forks source link

Using .transfer to send eth is bad practice. #140

Closed code423n4 closed 3 years ago

code423n4 commented 3 years ago

Handle

tensors

Vulnerability details

Impact

Using .send or .transfer to send ETH is widely considered bad practice as it is dependent on gas costs of certain opcodes, which are subject to change. Future developements may break the functionality of the protocol.

See https://consensys.net/diligence/blog/2019/09/stop-using-soliditys-transfer-now/ for more info and safe ways to send ETH.

Clearwood commented 3 years ago

Duplicate of #96