Missing Events on State Changing Functions

[code423n4]

Handle

leastwood

Vulnerability details

Impact

Events are used by off-chain participants to track on-chain state changes. There are several functions that don't emit events:

• Setter functions outlined in MISOLauncher.sol
• ListFactory.setDividends()

There are potentially other functions also lacking the use of events.

Proof of Concept

https://github.com/sushiswap/miso/blob/master/contracts/Access/ListFactory.sol#L137-L139 https://github.com/sushiswap/miso/blob/master/contracts/MISOLauncher.sol

Tools Used

Slither

Recommended Mitigation Steps

Consider adding an event to reflect any state changes made within a contract.

[Clearwood]

This is true but state changes can be monitored without events, does not constitute a security problem

[ghoul-sol]

making this a non-critical as it is best practices recommendation