code-423n4 / 2021-09-sushitrident-2-findings

0 stars 0 forks source link

Anyone can subscribe on behalf of other users #69

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Handle

pauliax

Vulnerability details

Impact

function subscribe does not verify the owner of the position so anyone can re-stake any positions to different incentives. This doesn't create any harm for the user as they can stake one position into as many incentives as they want but still I think this should be left for the user's responsibility.

Recommended Mitigation Steps

Consider adding auth to function subscribe to verify the sender.

alcueca commented 2 years ago

Chose #77 as best description