search

code-423n4 / 2021-09-sushitrident-findings

0 stars 0 forks source link

Events not emitted while changing state variables in constructor #2

Open code423n4 opened 3 years ago

code423n4 commented 3 years ago

Handle

hack3r-0m

Vulnerability details

Impact

https://github.com/sushiswap/trident/blob/9130b10efaf9c653d74dc7a65bde788ec4b354b5/contracts/deployer/MasterDeployer.sol#L29

event BarFeeUpdated(uint256 indexed _barFee); should be emitted in the constructor for actors relying on events to process data.

Tools Used

Manual Review

maxsam4 commented 3 years ago

There's no risk from this missing event. We are in fact considering dropping events altogether and using call traces for offchain indexing.

I might add it for prosperity but this is a 0 severity issue.

alcueca commented 3 years ago

Event emission issues are a non-critical. However, if events are emitted, they should be emitted consistently.