code-423n4 / 2021-09-swivel-findings

0 stars 0 forks source link

Order of params in event Mature #139

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Handle

pauliax

Vulnerability details

Impact

Different declared and the actual order of parameters for the Mature event:

event Mature(address indexed underlying, uint256 indexed maturity, uint256 maturityRate, uint256 matured); emit Mature(u, m, block.timestamp, currentExchangeRate);

maturityRate and matured are in the wrong order.

Recommended Mitigation Steps

This may trick the outside consumers of this event so consider fixing this.

0xean commented 2 years ago

dupe of #90

JTraversa commented 2 years ago

https://github.com/Swivel-Finance/gost/pull/174/commits/8b014e446d83961c56ba1d18b21926cadd471e2a