code-423n4 / 2021-09-swivel-findings

0 stars 0 forks source link

Can cancel the same order again #145

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

Handle

pauliax

Vulnerability details

Impact

While this does not bring any serious harm, I think function cancel should only be callable once for the same order so that you will not be flooded with Cancel events.

Recommended Mitigation Steps

Add a require !cancelled[hash];

JTraversa commented 2 years ago

Yea we considered this a bit and figured that the marginal UX improvement wasnt worth it over the marginal gas increase 🤷