search

code-423n4 / 2021-09-wildcredit-findings

0 stars 0 forks source link

`InterestRateModel` Constructor doesn't have checks for _minRate, _lowRate and _highRate, while setters do #109

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Handle

GalloDaSballo

Vulnerability details

Impact

Constructor doesn't have any checks on input parameters https://github.com/code-423n4/2021-09-wildcredit/blob/c48235289a25b2134bb16530185483e8c85507f8/contracts/InterestRateModel.sol#L36

This is in contradiction with the setters, https://github.com/code-423n4/2021-09-wildcredit/blob/c48235289a25b2134bb16530185483e8c85507f8/contracts/InterestRateModel.sol#L43

which are all checking for the relation between the values

Recommended Mitigation Steps

Add the checks in the constructor as well

require(_value < lowRate, "InterestRateModel: _value < lowRate"); require(_value < highRate, "InterestRateModel: _value < lowRate");

talegift commented 2 years ago

Duplicate #63