search

code-423n4 / 2021-09-wildcredit-findings

0 stars 0 forks source link

Improper File Imports #115

Open code423n4 opened 3 years ago

code423n4 commented 3 years ago

Handle

leastwood

Vulnerability details

Impact

There are two instances where a solidity file imports an interface using an incorrect path. These are located in UniswapV3Helper.sol and LendingPair.sol and are caused due to case specificity.

Proof of Concept

https://github.com/code-423n4/2021-09-wildcredit/blob/main/contracts/LendingPair.sol#L13 https://github.com/code-423n4/2021-09-wildcredit/blob/main/contracts/UniswapV3Helper.sol#L19

Tools Used

After attempting to run their test framework.

Recommended Mitigation Steps

Consider updating the path of the aforementioned imports to correctly match the target files.

talegift commented 3 years ago

Not a code error, it's related to the selective import of files into this repo.

This only impacts some tools such as Hardhat. When using Brownie, this issue was not present.

It was also fixed in the hardhat branch as stated in the README.

ghoul-sol commented 3 years ago

I'll keep this as the path should identical to directories names.