search

code-423n4 / 2021-09-wildcredit-findings

0 stars 0 forks source link

Incorrect import #12

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Handle

tabish

Vulnerability details

Impact

Detailed description of the impact of this finding.

Error HH409: Trying to import ./interfaces/univ3/INonFungiblePositionManager.sol from contracts/UniswapV3Helper.sol, but it has an incorrect casing.

https://github.com/code-423n4/2021-09-wildcredit/blob/c48235289a25b2134bb16530185483e8c85507f8/contracts/UniswapV3Helper.sol#L19

Recommended Mitigation Steps

import should be import ./interfaces/uniV3/INonFungiblePositionManager.sol

talegift commented 2 years ago

Not a code error, it's related to the selective import of files into this repo.

This only impacts some tools such as Hardhat. When using Brownie, this issue was not present.

It was also fixed in the hardhat branch as stated in the README.

ghoul-sol commented 2 years ago

Other wardens reported this as a single issue. I'm going to merge #11 #12 #13 and #14 into a single issue #11