search

code-423n4 / 2021-09-wildcredit-findings

0 stars 0 forks source link

Wrong implementation of _sqrt function #27

Closed code423n4 closed 3 years ago

code423n4 commented 3 years ago

Handle

pants

Vulnerability details

Use a library for that. Don't implement yourself. https://github.com/code-423n4/2021-09-wildcredit/blob/main/contracts/UniswapV3Helper.sol line 187.

talegift commented 3 years ago

Just because it's re-implemented doesn't make it wrong. Please demonstrate an exploit.

This is a 0-risk gas optimization at best.

Marking as invalid.

ghoul-sol commented 3 years ago

No exploit description, invalid