Open code423n4 opened 2 years ago
WatchPug
https://github.com/code-423n4/2021-09-wildcredit/blob/c48235289a25b2134bb16530185483e8c85507f8/contracts/LendingPair.sol#L338-L339
_supplyBalanceConverted is unnecessary when fromToken and toToken are the same. Change to _supplyOf can save gas.
_supplyBalanceConverted
fromToken
toToken
_supplyOf
uint creditA = _supplyBalanceConverted(_account, tokenA, tokenA, priceA, priceA) * colFactorA / 100e18; uint creditB = _supplyBalanceConverted(_account, tokenB, tokenA, priceB, priceA) * colFactorB / 100e18;
Change to:
uint creditA = _supplyOf(tokenA, _account) * colFactorA / 100e18; uint creditB = _supplyBalanceConverted(_account, tokenB, tokenA, priceB, priceA) * colFactorB / 100e18;
Handle
WatchPug
Vulnerability details
https://github.com/code-423n4/2021-09-wildcredit/blob/c48235289a25b2134bb16530185483e8c85507f8/contracts/LendingPair.sol#L338-L339
_supplyBalanceConverted
is unnecessary whenfromToken
andtoToken
are the same. Change to_supplyOf
can save gas.Recommendation
Change to: