code-423n4 / 2021-09-wildcredit-findings

0 stars 0 forks source link

`setLowRate()` Misleading error message #89

Closed code423n4 closed 2 years ago

code423n4 commented 3 years ago

Handle

WatchPug

Vulnerability details

https://github.com/code-423n4/2021-09-wildcredit/blob/main/contracts/InterestRateModel.sol#L49-L53

function setLowRate(uint _value) external onlyOwner {
    require(_value < highRate, "InterestRateModel: _value < lowRate");
    lowRate = _timeRateToBlockRate(_value);
    emit NewLowRate(_value);
}

Should be "InterestRateModel: _value < highRate".

talegift commented 3 years ago

Duplicate #63

ghoul-sol commented 2 years ago

I disagree about the duplicate, this is about message. Non-critical.

ghoul-sol commented 2 years ago

duplicate of #59