code-423n4 / 2021-09-yaxis-findings

0 stars 0 forks source link

Missing parameter validation #107

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

Handle

cmichel

Vulnerability details

Some parameters of functions are not checked for invalid values:

Impact

Wrong user input or wallets defaulting to the zero addresses for a missing input can lead to the contract needing to redeploy or wasted gas.

Recommended Mitigation Steps

Validate the parameters.

Haz077 commented 2 years ago

I don't see any risk in that, as all the mentioned functions are constructors

GalloDaSballo commented 2 years ago

Agree with sponsor, no risk here

At the same time, having checks in constructor is industry standard, will set to Non-Critical