code-423n4 / 2021-09-yaxis-findings

0 stars 0 forks source link

Lack of Documentation in Swaps.sol #164

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Handle

tensors

Vulnerability details

https://github.com/code-423n4/2021-09-yaxis/blob/a78d392156b90f8ac27de6d57cb0de2697d480d5/contracts/token/Swap.sol#L56

The function IsYax is only defined as an interface. You should add the definition to the codebase and verify that it behaves as desired.

GalloDaSballo commented 2 years ago

While this is a kind gesture, I believe the contract to be out of scope, hence the finding is invalid