search

code-423n4 / 2021-09-yaxis-findings

0 stars 0 forks source link

Harvester: Unneeded safemath subtraction in removeStrategy() #68

Closed code423n4 closed 3 years ago

code423n4 commented 3 years ago

Handle

hickuphh3

Vulnerability details

Impact

L141: The safemath subtraction in strategies[_vault].addresses[index] = strategies[_vault].addresses[tail.sub(1)]; is unnecessary because this code block will not be executed in the case tail = strategies[_vault].addresses.length = 0 (vault has no strategies, found will be false).

Recommended Mitigation Steps

strategies[_vault].addresses[index] = strategies[_vault].addresses[tail - 1];

GainsGoblin commented 3 years ago

Duplicate of #46

GalloDaSballo commented 3 years ago

Duplicate of #46