code-423n4 / 2021-09-yaxis-findings

0 stars 0 forks source link

Deposit event should emit amount or shares #80

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Handle

pauliax

Vulnerability details

Impact

event Deposit declares a parameter named 'amount', but emits 'shares': event Deposit(address indexed account, uint256 amount) emit Deposit(msg.sender, _shares);

Recommended Mitigation Steps

This looks confusing so consider either renaming the parameter or using '_amount' value here.

Haz077 commented 2 years ago

It can be seen as amount of shares, in my opinion, this shouldn't be considered as an issue.

GalloDaSballo commented 2 years ago

Agree with sponsor, this is preference. Disputed