Closed code423n4 closed 2 years ago
pauliax
event Deposit declares a parameter named 'amount', but emits 'shares': event Deposit(address indexed account, uint256 amount) emit Deposit(msg.sender, _shares);
This looks confusing so consider either renaming the parameter or using '_amount' value here.
It can be seen as amount of shares, in my opinion, this shouldn't be considered as an issue.
Agree with sponsor, this is preference. Disputed
Handle
pauliax
Vulnerability details
Impact
event Deposit declares a parameter named 'amount', but emits 'shares': event Deposit(address indexed account, uint256 amount) emit Deposit(msg.sender, _shares);
Recommended Mitigation Steps
This looks confusing so consider either renaming the parameter or using '_amount' value here.