code-423n4 / 2021-09-yaxis-findings

0 stars 0 forks source link

Unused imports #89

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

Handle

pauliax

Vulnerability details

Impact

There are unused imports. They will increase the size of deployment with no real benefit. An example of such an import is: import "../interfaces/IVault.sol"; in Controller or import "../interfaces/IController.sol"; in LegacyController.

Recommended Mitigation Steps

Consider removing unused imports to save some gas.

uN2RVw5q commented 2 years ago

They will increase the size of deployment

This is incorrect. An unused import will not affect the deployment cost of a contract. I would not consider this to be a gas-optimization. Maybe style or code quality.

GalloDaSballo commented 2 years ago

Agree with sponsor that finding is non-critical code-style