Haz077
commented
2 years ago I don't think this is necessary.
Open code423n4 opened 2 years ago
Haz077
commented
2 years ago I don't think this is necessary.
GalloDaSballo
commented
2 years ago Agree with Warden on MAGIC_NUMBERS, using a constants avoid issues, makes the code more readable and easier to maintain
Non-critical finding
Handle
pauliax
Vulnerability details
Impact
Style issues that you may want to apply or reject, no impact on security. Grouping them together as one submission to reduce waste. Consider fixing or ignoring them, up to you.
There are hardcoded magic numbers, e.g. in Controller 10 is the initial value for maxStrategies. It would make code more readable and maintainable if you extract such numbers as constants.
In function reorderStrategies there two require statements: require(manager.allowedStrategies(_strategy1), "!_strategy1"); require(manager.allowedStrategies(_strategy2), "!_strategy2");
that can be replaced to reuse an existing modifier: onlyStrategy(_strategy1) onlyStrategy(_strategy2)