code-423n4 / 2021-09-yaxis-findings

0 stars 0 forks source link

Redundant `notHalted` modifier in `depositMultiple` #97

Closed code423n4 closed 3 years ago

code423n4 commented 3 years ago

Handle

hrkrshnn

Vulnerability details

Redundant notHalted modifier in depositMultiple

Since the call to deposit already has the notHalted modifier, doing the check during depositMultiple is redundant. Saves at least 100 gas.

https://github.com/code-423n4/2021-09-yaxis/blob/main/contracts/v3/Vault.sol#L194

GalloDaSballo commented 3 years ago

Duplicate of #70