search

code-423n4 / 2021-10-ambire-findings

0 stars 0 forks source link

Unnecessary storage variables #29

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

Handle

WatchPug

Vulnerability details

https://github.com/code-423n4/2021-10-ambire/blob/bc01af4df3f70d1629c4e22a72c19e6a814db70d/contracts/wallet/Zapper.sol#L69-L72

Some storage variables include admin, lendingPool and aaveRefCode are unnecessary as they will never be changed.

Change to immutable can save gas.

Ivshti commented 2 years ago

Duplicate of #5

GalloDaSballo commented 2 years ago

Using this one as the original issue as it's concise and the description doesn't have an extra variable