Open code423n4 opened 2 years ago
WatchPug
https://github.com/code-423n4/2021-10-ambire/blob/bc01af4df3f70d1629c4e22a72c19e6a814db70d/contracts/wallet/QuickAccManager.sol#L128-L128
The variables TRANSFER_TYPEHASH, TXNS_TYPEHASH, BUNDLE_TYPEHASH are named in all caps, which implies that they are constants. However, they are not being marked as constant. Mark them as constant can also help save some gas.
TRANSFER_TYPEHASH
TXNS_TYPEHASH
BUNDLE_TYPEHASH
constant
resolved in https://github.com/AmbireTech/adex-protocol-eth/commit/687a027d27693f18a5d547fc95f0af358a1de12e
Agreed, the sponsor has applied the improvement in a subsequent PR
Handle
WatchPug
Vulnerability details
https://github.com/code-423n4/2021-10-ambire/blob/bc01af4df3f70d1629c4e22a72c19e6a814db70d/contracts/wallet/QuickAccManager.sol#L128-L128
The variables
TRANSFER_TYPEHASH
,TXNS_TYPEHASH
,BUNDLE_TYPEHASH
are named in all caps, which implies that they are constants. However, they are not being marked asconstant
. Mark them asconstant
can also help save some gas.